fix(rg): cap brace alternation recursion depth#1743
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | afbf3da | Commit Preview URL | May 25 2026, 04:35 PM |
Brace-alternation parsing in rg's glob converter recursed unboundedly on attacker-controlled input, enabling CPU exhaustion and stack-overflow aborts. Reachable from user-controlled inputs (-g, --iglob, --type-add, --ignore-file) and VFS ignore files, so mitigated at conversion time. Add RG_GLOB_MAX_BRACE_DEPTH (32) and route conversion through glob_to_regex_with_depth(pattern, depth). At the cap, return a literal-escaped regex for the remaining pattern instead of recursing further. glob_alternation_to_regex accepts a recursion_depth parameter and returns None when the cap is reached. Rebased on current main; original PR #1743 by chaliy.
chaliy
force-pushed
the
2026-05-25-propose-fix-for-rg-brace-vulnerability
branch
from
38dac03 to
afbf3da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
rg’s glob converter recursed unboundedly on attacker-controlled input, enabling CPU exhaustion and stack-overflow aborts.-g,--iglob,--type-add,--ignore-file, etc.) and VFS ignore files, so it must be mitigated at conversion time.Description
RG_GLOB_MAX_BRACE_DEPTHand route conversion through a newglob_to_regex_with_depth(pattern, depth)entrypoint to track recursion depth.glob_to_regex_with_depthfalls back to returning a literal-escaped regex for the remaining pattern instead of recursing further.glob_alternation_to_regexto accept adepthparameter, returnNonewhen the cap is reached, and callglob_to_regex_with_depthfor each alternative.glob_brace_alternation_depth_limit_does_not_expand_nested_patternto assert the depth-limit fallback behavior.Testing
rg::tests::glob_brace_alternation_depth_limit_does_not_expand_nested_pattern, which passed.cargo test -p bashkit(library test run) which completed with the test-suite passing for the executed targets in this environment.Codex Task