feat(rg): sort by modified time#1720
Open
chaliy wants to merge 1 commit into
Open
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 9ff3cfc | Commit Preview URL | May 23 2026, 07:15 PM |
2072885 to
9ff3cfc
Compare
Contributor
Author
|
Temporarily closing/reopening to retrigger missing pull_request CI checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Implement real sorting behavior for rg
--sort/--sortrover recursive file candidates.--sort modifiedand--sortr modifiednow order by VFS mtime,--sort createdorders by creation time, and--sort noneskips the path sort.Why
Bashkit rg previously accepted non-path sort modes but still path-sorted results. Real ripgrep supports metadata sorting, so these flags were parse-only parity gaps.
How
Carry file metadata through rg recursive candidates, centralize candidate sorting by requested sort key, bypass indexed search for non-path sorts, refresh help text, and add timed real-rg differential cases with controlled mtimes.
Risk
--sort accessedfalls back to mtime because the current VFS metadata contract does not expose access time.Checklist
just pre-prpassed locally