Skip to content

feat(rg): honor parent ignore files#1684

Merged
chaliy merged 1 commit into
mainfrom
2026-05-22-rg-batch-10
May 22, 2026
Merged

feat(rg): honor parent ignore files#1684
chaliy merged 1 commit into
mainfrom
2026-05-22-rg-batch-10

Conversation

@chaliy
Copy link
Copy Markdown
Contributor

@chaliy chaliy commented May 22, 2026

What

Makes rg seed recursive searches with ignore rules from parent directories.

Why

Real rg honors parent .ignore, .rgignore, and applicable .gitignore files when searching a child root, unless --no-ignore-parent is set. Bashkit only loaded ignore files inside the searched root.

How

  • Adds parent ignore rule loading before recursive walk roots are queued.
  • Reuses existing local ignore parsing and git-repository checks.
  • Preserves --no-ignore and --no-ignore-parent behavior.
  • Adds unit and differential coverage against real rg for parent ignore and --no-ignore-parent.

Risk

  • Low / Medium
  • Recursive search filtering changes for child roots with parent ignore files; explicit file searches still bypass ignore filtering as before.

Checklist

  • Tests added or updated
  • Backward compatibility considered

@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
bashkit bb0acd5 Commit Preview URL May 22 2026, 05:57 PM

@chaliy chaliy merged commit f0ac61e into main May 22, 2026
34 checks passed
@chaliy chaliy deleted the 2026-05-22-rg-batch-10 branch May 22, 2026 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant