feat: ambitious refactor and release v1.0.0 - #15
Merged
Conversation
Repository owner
deleted a comment from
nightandwknd
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Plugin Overhaul
UnityWebGLSignalRSignalROptionsfor auth, transport, timeouts, reconnect configInvoke(string, params object[])replaces 10 overloadsIsConnectedproperty,IDisposablesupportUnityWebGLSignalR.asmdef) for proper referencesBug Fixes (8)
invokeCallback(malloc without free)InvokeJs(empty string, "0", "false")On()crashstart())Dispose()static dictionary leakTesting
CI/CD
ci.yml— Runs on PRs: test → build → smokerelease.yml— Runs on merge tomain: version → build WebGL + export.unitypackage(parallel) → commit wwwroot → tag → GitHub Releasetest.yml— Reusable workflow used by CIsetup-unitycomposite action for shared runner setupworkflow_dispatchWebGL Template
Assets/WebGLTemplates/SignalR/) with SignalR JS client baked inCleanup
version.txt— version derived from git tagsExportPackagenamespaced toUnityWebGLSignalR.Editorsignalr.ps1switched fromnugetCLI todotnet restore[SerializeField]instead ofGameObject.FindTest Plan
version:1.0.0label