Skip to content
This repository was archived by the owner on Sep 6, 2018. It is now read-only.

Prevent Update Cycle On Unsortable Header Click - #18

Open
mkaulig wants to merge 1 commit into
evancz:masterfrom
mkaulig:nonsortable-columns
Open

Prevent Update Cycle On Unsortable Header Click#18
mkaulig wants to merge 1 commit into
evancz:masterfrom
mkaulig:nonsortable-columns

Conversation

@mkaulig

@mkaulig mkaulig commented Feb 19, 2017

Copy link
Copy Markdown

Render header cells without an onClick handler, if they are unsortable.

This prevents an useless update cycle, caused by clicking the header
cell of an usortable column.
To make this possible the signature of the thead field in the
customization record is changed to accept a list of attributes instead
of a single attribute, which enables to pass an empty list if no onClick
handler should be added.

This commit breaks the public API. I understand that this is a problem, but it breaks only for people not using the default thead configuration and opens the possibility to add more attributes to the header cells in the future without breaking things.

Render header cells without an onClick handler, if they are unsortable.
This prevents an useless update cycle, caused by clicking the header
cell of an usortable column.
To make this possible the signature of the thead field in the
customization record is changed to accept a list of attributes instead
of a single attribute, which enables to pass an empty list if no onClick
handler should be added
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant