Skip to content

Fix sstream_convert for types not constructible from const char* #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evaleev merged 1 commit into from
May 20, 2026
Merged

Fix sstream_convert for types not constructible from const char* #418

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions include/libint2/numeric.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,15 +198,30 @@ inline int get_max_digits10(const Real& value) {
return std::numeric_limits<Real>::max_digits10;
}

namespace detail {
template <typename To>
typename std::enable_if<std::is_constructible<To, const char*>::value, To>::type
sstream_convert_extract(std::stringstream& ss) {
return To(ss.str().c_str());
}

template <typename To>
typename std::enable_if<!std::is_constructible<To, const char*>::value, To>::type
sstream_convert_extract(std::stringstream& ss) {
To to;
ss >> to;
return to;
}
} // namespace detail

template <typename To, typename From>
typename std::enable_if<!std::is_same<typename std::decay<To>::type,
typename std::decay<From>::type>::value,
To>::type
sstream_convert(From&& from) {
std::stringstream ss;
ss << std::scientific << std::setprecision(get_max_digits10(from)) << from;
To to(ss.str().c_str());
return to;
return detail::sstream_convert_extract<To>(ss);
}

template <typename To>
Expand Down
Loading