Skip to content

Resolves #106: Implementing skip-empty-xacts. #120

Open
bahaa wants to merge 3 commits into
eulerto:masterfrom
bahaa:skip_empty_xacts
Open

Resolves #106: Implementing skip-empty-xacts. #120
bahaa wants to merge 3 commits into
eulerto:masterfrom
bahaa:skip_empty_xacts

Conversation

@bahaa

@bahaa bahaa commented Jun 28, 2019

Copy link
Copy Markdown

Adding new parameter skip-empty-xacts. I chose the same parameter name as Postgres' test_decoding.

This should resolve #106.

@joekohlsdorf

Copy link
Copy Markdown

What is the reasoning behind not defaulting this to true?

@bahaa

bahaa commented Aug 2, 2019

Copy link
Copy Markdown
Author

@joekohlsdorf backward compatibility. I think the plugin should behave the same for current users. Current users already get empty transactions and I think they are dealing with them already.

@joekohlsdorf

Copy link
Copy Markdown

In this particular case I would argue that the users aren't doing anything with empty transactions. So there is nothing lost by removing them because they contain no information at all.
They are just wasting network bandwidth and CPU cycles, depending on the use case this can require a substantial amount of additional processing.

@qweeze

qweeze commented Feb 8, 2020

Copy link
Copy Markdown

Any chance of merging this PR?

@eulerto

eulerto commented Feb 10, 2020

Copy link
Copy Markdown
Owner

@qweeze this PR is incomplete. It should be implemented in both format. @bahaa do you want to update this PR? Also, use a single commit.

@bahaa

bahaa commented Feb 10, 2020

Copy link
Copy Markdown
Author

@eulerto sure. I can update it on the weekend. What do you mean by "both formats"?

@jmealo

jmealo commented Mar 31, 2020

Copy link
Copy Markdown

@bahaa: there's an option format-version which can be either 1 or 2 (see README) -- anything new needs to support both versions.

@bahaa

bahaa commented Mar 31, 2020

Copy link
Copy Markdown
Author

@jmealo Thank you. I forked my version before there was support for two formats. I'll try to fix it this weekend.

@ajitj

ajitj commented Oct 25, 2020

Copy link
Copy Markdown

Looking forward to getting this feature. @bahaa any update on this?
Thanks

@llehtinen

Copy link
Copy Markdown

@bahaa would be great to get this merged

@jehanzebqayyum

Copy link
Copy Markdown

@bahaa pls merge this.

@adrijshikhar

Copy link
Copy Markdown

@bahaa if you are unable to work on this, I will be more than happy to take it further.

@bahaa

bahaa commented Jun 15, 2022

Copy link
Copy Markdown
Author

@adrijshikhar sure. I'd be so glad if you do.

@adrijshikhar

Copy link
Copy Markdown

sure i will pick this up

@adrijshikhar

Copy link
Copy Markdown

#248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Getting an overwhelming amount of transactions with empty change sets despite using add-tables

9 participants