Remove /add-systems config wizard page#8260
Conversation
The wizard page at /add-systems (ConfigWizard) along with its AWS and Okta scanner sub-steps is unused. Single-system creation is still available via /add-systems/manual and the inline AddNewSystemModal; bulk vendor add is still available at /add-systems/multiple. - Delete pages/add-systems/index.tsx and the features/config-wizard/ directory (AddSystem, AuthenticateAwsForm, AuthenticateOktaForm, AuthenticateScanner, ConfigWizardWalkthrough, ScanResults, ScannerLoading, OrganizationInfoForm, slices, helpers, types). - Drop ADD_SYSTEMS_ROUTE constant, "Add systems" nav entry and home module card. - Update breadcrumbs on /add-systems/manual and /add-systems/multiple to drop the now-dead parent link. - Point the empty-datamap GetStarted button at /add-systems/multiple. - Remove configWizardSlice from the redux store. - Update jest + cypress specs (delete config-wizard*.cy.ts, drop wizard setup steps from bulk-vendor-add.cy.ts, routes.cy.ts, systems.cy.ts, root-user-access.cy.ts). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
home.cy.ts no longer expects the "Add systems" home tile; nav-bar.cy.ts and root-user-access.cy.ts no longer expect the "Add systems-nav-link" sidebar entry. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ProtectedRoute uses findActiveNav to gate access; with no nav entry covering the path, it pushes the user to "/". The "Add systems" sidebar entry (path /add-systems) was previously the only match for the /add-systems/manual and /add-systems/multiple subpaths via startsWith, so removing it cut off access to both still-extant pages. Add hidden NAV_CONFIG entries for the manual and bulk routes, scoped to system:create, so the pages stay reachable without re-introducing a visible sidebar item. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Hi @adamsachs !
The more proper solution is to rewrite the add urls to be /systems/add-manual and /systems/add-multiple but that requires changing many files, unit and cypress tests. We can leave that to a followup.
|
thank you so much for this @lucanovera ! opened up over in https://github.com/ethyca/fidesplus/pull/3708 if you don't mind approving 🙏 |
Ticket ENG-3404
Description Of Changes
Removes the unused config wizard page at
/add-systemsalong with its AWS scanner and Okta scanner sub-steps. The wizard's only entry point was navigation that pointed to itself; single-system creation remains available via/add-systems/manualand the inlineAddNewSystemModal, and bulk vendor add remains at/add-systems/multiple.Screenshot showing page no longer present:

Code Changes
pages/add-systems/index.tsxfeatures/config-wizard/(AddSystem, AuthenticateAwsForm, AuthenticateOktaForm, AuthenticateScanner, ConfigWizardWalkthrough, ScanResults, ScannerLoading, OrganizationInfoForm, slices, helpers, types)config-wizard.cy.tsandconfig-wizard-plus.cy.tsADD_SYSTEMS_ROUTEconstant, the "Add systems" sidebar nav entry, and the "Add systems" home module cardconfigWizardSliceregistration fromapp/store.ts/add-systems/manualand/add-systems/multipleGetStartedbutton at/add-systems/multiplenav-config.test.ts,tile-config.test.ts) to match the new nav/tile shaperoutes.cy.ts,systems.cy.ts,bulk-vendor-add.cy.ts,root-user-access.cy.ts) to drop wizard-dependent setup stepsSteps to Confirm
/add-systems— should 404/add-systems/manual— single-system creation form still loads, breadcrumb shows "Add systems / New system" with "Add systems" no longer a link/add-systems/multiple— bulk vendor add still loads, breadcrumb shows "Add systems / Choose vendors" with "Add systems" no longer a link/systems, click the "Add system" / "Add new system" button — still routes to/add-systems/manual(or shows the Compass-enabled dropdown with manual + multiple options)Get Startedmodal still has a working "Add Systems" button (now goes to/add-systems/multiple)Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works🤖 Generated with Claude Code