ENG-3865: Fix status rendering for synthetic PBAC policy labels#8224
Open
galvana wants to merge 7 commits into
Open
ENG-3865: Fix status rendering for synthetic PBAC policy labels#8224galvana wants to merge 7 commits into
galvana wants to merge 7 commits into
Conversation
Use policy_id instead of policy to determine suppression status in the log table, findings table, and violation detail drawer. Adds suppressed boolean to PolicyViolationAggregate type for the findings table. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
galvana
requested review from
lucanovera and
thabofletcher
and removed request for
speaker-ender and
thabofletcher
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
policy_idinstead ofpolicyto determine suppression status in the log table, findings table, and violation detail drawersuppressedboolean toPolicyViolationAggregatetype for the findings tableDepends on: fidesplus PR (backend changes that synthesize the labels)
Test plan
🤖 Generated with Claude Code