Security: Redux store exposed on window for testing#8185
Open
tomaioo wants to merge 1 commit into
Open
Conversation
In `clients/admin-ui/global.d.ts`, the `__REDUX_STORE__` is exposed on the `Window` interface. While this is intended for Cypress testing, it could leak sensitive application state if accessed in production. Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
Contributor
|
@tomaioo is attempting to deploy a commit to the Ethyca Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: Redux store exposed on window for testing
Problem
Severity:
Medium| File:clients/admin-ui/global.d.ts:L10In
clients/admin-ui/global.d.ts, the__REDUX_STORE__is exposed on theWindowinterface. While this is intended for Cypress testing, it could leak sensitive application state if accessed in production.Solution
Ensure this is only exposed in test environments. Consider using environment checks or build-time configuration to exclude this from production builds.
Changes
clients/admin-ui/global.d.ts(modified)