Recover from panics in the datasource discovery hook#320
Open
damilolaedwards wants to merge 1 commit into
Open
Recover from panics in the datasource discovery hook#320damilolaedwards wants to merge 1 commit into
damilolaedwards wants to merge 1 commit into
Conversation
OnDiscover runs on the background discovery goroutine with no supervisor above it. A panic anywhere in module activation or resource registration triggered by a newly discovered datasource would escape unrecovered and crash the whole server, taking down every in-flight request along with it. Wrap the hook call so a panic is caught, logged, and the discovery loop keeps running instead of taking the process down with it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OnDiscover runs on the background discovery goroutine with nothing above it
to catch a panic. A bug in module activation or resource registration
triggered by a newly discovered datasource would escape unrecovered and
crash the whole server, taking every in-flight request down with it.
Wraps the hook invocation so a panic is caught and logged instead of
killing the process, and the discovery loop keeps running on the next tick.
Test plan
go test -race ./pkg/proxy/...confirms the client survives and stays usable for a subsequent call
go build ./...,go vet ./...