fix: include bootnodes in /status and /status/peers#5457
Merged
Conversation
acud
approved these changes
May 11, 2026
akrem-chabchoub
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Fixes #5111. The peer counts reported by
/peers,/status, and/status/peersdisagree on any node connected to a bootnode.PR #4909 ("fix: exclude bootnode from protocol requests") made
kademlia's
EachConnectedPeer/EachConnectedPeerRevalways filterbootnodes out via
excludeFromIterator. That is the correct policyfor protocol traffic (pushsync, retrieval, puller, salud, kad's own
random-peer selection), but it also silently dropped bootnodes from
the two operator-facing status views, which iterate via the same
method. Meanwhile
/peersreadsp2p.Peers()directly and neverwent through the kademlia filter — so it kept showing bootnodes.
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):
AI Disclosure