Skip to content

fix: include bootnodes in /status and /status/peers#5457

Merged
martinconic merged 1 commit into
masterfrom
fix-5111-bootnodes-in-status
May 12, 2026
Merged

fix: include bootnodes in /status and /status/peers#5457
martinconic merged 1 commit into
masterfrom
fix-5111-bootnodes-in-status

Conversation

@martinconic
Copy link
Copy Markdown
Contributor

Checklist

  • I have read the coding guide.
  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

Fixes #5111. The peer counts reported by /peers, /status, and
/status/peers disagree on any node connected to a bootnode.

PR #4909 ("fix: exclude bootnode from protocol requests") made
kademlia's EachConnectedPeer / EachConnectedPeerRev always filter
bootnodes out via excludeFromIterator. That is the correct policy
for protocol traffic (pushsync, retrieval, puller, salud, kad's own
random-peer selection), but it also silently dropped bootnodes from
the two operator-facing status views, which iterate via the same
method. Meanwhile /peers reads p2p.Peers() directly and never
went through the kademlia filter — so it kept showing bootnodes.

Open API Spec Version Changes (if applicable)

Motivation and Context (Optional)

Related Issue (Optional)

Screenshots (if appropriate):

AI Disclosure

  • This PR contains code that has been generated by an LLM.
  • I have reviewed the AI generated code thoroughly.
  • I possess the technical expertise to responsibly review the code generated in this PR.

@martinconic martinconic added this to the 2026 milestone May 11, 2026
@martinconic martinconic self-assigned this May 11, 2026
@martinconic martinconic merged commit 56a033c into master May 12, 2026
15 checks passed
@martinconic martinconic deleted the fix-5111-bootnodes-in-status branch May 12, 2026 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exclude bootnode from protocol requests issue

3 participants