fix(openapi): align Swarm/SwarmCommon spec with handler implementations#5452
Merged
Conversation
martinconic
requested review from
acud,
akrem-chabchoub,
gacevicljubisa,
janos and
sbackend123
and removed request for
acud
sbackend123
approved these changes
May 12, 2026
gacevicljubisa
approved these changes
May 12, 2026
Member
gacevicljubisa
left a comment
gacevicljubisa
left a comment
There was a problem hiding this comment.
Should we apply the same GET method handler for the /pss/subscribe/{topic} and /gsoc/subscribe/{address} for consistency?
…h WebSocket handshake
Contributor
Author
Good catch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Issue #4974 — fix accumulated drift between handlers in pkg/api/ and the hand-written OpenAPI spec so generated clients (bee-js) match runtime behavior.
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):
AI Disclosure