fix: set fromBlock latest on eth_newFilter for event listeners - #5181
Open
official-burak wants to merge 1 commit into
Open
fix: set fromBlock latest on eth_newFilter for event listeners#5181official-burak wants to merge 1 commit into
official-burak wants to merge 1 commit into
Conversation
Some RPC providers reject eth_newFilter without an explicit fromBlock as an unbounded historical range, which breaks contract.on(). The JSON-RPC default is latest; send it explicitly when the filter does not already set fromBlock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5061.
FilterIdEventSubscribersendseth_newFilterwith onlyaddressandtopics. The JSON-RPC spec defaultsfromBlocktolatest, but some providers (Chainstack and others with historical range limits) treat a missingfromBlockas an unbounded range and reject the request. That makescontract.on()/provider.on(filter)fail even though the listener only needs new logs.When the filter does not already specify
fromBlock, this setsfromBlock: "latest"so live subscriptions match the spec default and those providers.Existing explicit
fromBlockvalues are left unchanged. Test uses the in-process JsonRpc mock fromtest-providers-jsonrpc.ts.