fix: guard CCIP-Read dataSlice against short error.data to prevent BUFFER_OVERRUN - #5176
Open
yutonakamura-dev wants to merge 1 commit into
Open
fix: guard CCIP-Read dataSlice against short error.data to prevent BUFFER_OVERRUN#5176yutonakamura-dev wants to merge 1 commit into
yutonakamura-dev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a CCIP-Read enabled contract reverts with empty or short
error.data(e.g.0x), the OffchainLookup check in#callcrashes withBUFFER_OVERRUNinstead of propagating the original call error.This happens because the condition on line 1034 checks
error.datafor truthiness —"0x"is truthy — then immediately passes it todataSlice(error.data, 0, 4), which throws when the data is shorter than 4 bytes.Affects any ENS offchain name lookup (e.g.
.xyzdomains via CCIP resolvers) where the resolver reverts without data.Root Cause
Fix
Add a
dataLengthguard beforedataSlice.dataLengthis already imported and used elsewhere in the file (line 1711).Reproduction
Closes #4982