feat(tests): add EIP-2780 coverage gap tests - #3318
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #3318 +/- ##
================================================
Coverage 93.50% 93.50%
================================================
Files 624 624
Lines 37070 37070
Branches 3394 3394
================================================
Hits 34661 34661
Misses 1653 1653
Partials 756 756
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Forwarding from previous review via @marioevz: (LouisTsai-Csie#16) |
LouisTsai-Csie
left a comment
There was a problem hiding this comment.
LGTM, only leave a comment on the docstrings:
we should simplify them if the test or function already clearly expresses its intent.
I've noticed docstrings getting longer in the repo, which creates maintenance overhead. When tests or functions change, we'll need to update the documentation too, which becomes kind of review burden. What do you think?
|
Thx @LouisTsai-Csie! Addressed! |
Description
Rebase of #3296 now that #3266 has merged. Adds three EIP-2780 coverage gaps, all filled green:
test_intrinsic_gas_floor_boundary_all_tx_types: theintrinsic - 1rejection boundary for every transaction type (previously only types 0 and 4 had one).test_setcode_tx_across_amsterdam_transition: a type-4 transaction straddling the fork boundary, pinning the per-authorization cost migrating from the pre-fork intrinsic (AUTH_PER_EMPTY_ACCOUNT) into the decomposed intrinsic plus top-frame charges, cross-checked against a hand-derived per-fork decomposition.test_calldata_floor_with_authorizations: a binding calldata floor on a type-4 transaction, pinning that authorization tuples add no floor tokens while the masked delegation still lands, and that one gas below the floor rejects.Related Issues or PRs
Supersedes #3296; part of the EIP-2780 coverage item in #3217.
Checklist
just static<type>(<area>): <title>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.Cute Animal Picture