feat(test-tests): add engine payload attribute and genesis parity tests - #3309
Merged
danceratopz merged 2 commits intoAug 6, 2026
Merged
Conversation
spencer-tb
force-pushed
the
pr3300-followup-tests
branch
from
August 5, 2026 10:38
3279642 to
5dfe545
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #3309 +/- ##
===================================================
- Coverage 93.49% 93.23% -0.26%
===================================================
Files 624 624
Lines 37056 37056
Branches 3394 3394
===================================================
- Hits 34647 34551 -96
- Misses 1653 1720 +67
- Partials 756 785 +29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
spencer-tb
added
C-feat
spencer-tb
changed the title
spencer-tb
marked this pull request as ready for review
August 5, 2026 10:58
danceratopz
approved these changes
Aug 6, 2026
danceratopz
left a comment
danceratopz
left a comment
Member
There was a problem hiding this comment.
LGTM! Claude verified via mutation testing that the tests catch what they say on the tin.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds two regression guards following the #3300 review.
Fixes a bug I added by only adding the target gas limit to payload attributes when the version > 4.
Related Issues or PRs
Follow-up to #3300.
Checklist
just static<type>(<area>): <title>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.Cute Animal Picture