feat(test-logging,test-consume): add ms-precision lifecycle logging to consume enginex - #3306
Open
danceratopz wants to merge 1 commit into
Open
feat(test-logging,test-consume): add ms-precision lifecycle logging to consume enginex#3306danceratopz wants to merge 1 commit into
danceratopz wants to merge 1 commit into
Conversation
Add millisecond precision to log timestamps (previously truncated to
seconds) and emit one structured, grep-able INFO line per lifecycle
phase transition in the enginex simulator:
⏱ phase=<name> group=<id> ms=<duration>
Phases bracketed per pre-alloc group cycle:
- group_start (with idle_ms: xdist dispatch wait since the previous
test protocol ended on the worker)
- fixture_load (test fixture JSON read+parse, cache misses only)
- pre_alloc_load (pre-alloc group JSON read+parse, cache misses only)
- genesis_prep (genesis/alloc to_json conversion, cache misses only)
- genesis_serialize (genesis JSON dump before client start)
- client_start (hive start-client API call: container create, client
boot and check-live wait)
- client_stop (hive stop-client API call)
Together with the existing per-test START/END lines (now ms-precision)
this makes the complete->next-start "teardown gap" between group
cycles exactly decomposable from the per-worker log files.
danceratopz
added
C-feat
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #3306 +/- ##
================================================
Coverage 93.49% 93.49%
================================================
Files 625 624 -1
Lines 37039 37056 +17
Branches 3392 3394 +2
================================================
+ Hits 34630 34647 +17
Misses 1653 1653
Partials 756 756
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TLDR: This PR adds millisecond precision to log timestamps to enable more precise analysis of container lifecycles in the enginex simulator in order to explore potential optimizations. It also adds ms resolution to fill & execute.
Add millisecond precision to log timestamps (previously truncated to seconds) and emit one structured, grep-able INFO line per lifecycle phase transition in the enginex simulator:
Phases bracketed per pre-alloc group cycle:
group_start(with idle_ms: xdist dispatch wait since the previous test protocol ended on the worker)fixture_load(test fixture JSON read+parse, cache misses only)pre_alloc_load(pre-alloc group JSON read+parse, cache misses only)genesis_prep(genesis/alloc to_json conversion, cache misses only)genesis_serialize(genesis JSON dump before client start)client_start(hive start-client API call: container create, client boot and check-live wait)client_stop(hive stop-client API call)Together with the existing per-test START/END lines (now ms-precision) this makes the complete->next-start "teardown gap" between group cycles exactly decomposable from the per-worker log files.
Related Issues or PRs
N/A.
Checklist
just static<type>(<area>): <title>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.Cute Animal Picture