perf(client): skip rlp check if rlp clearly not large enough - #3302
Draft
jochem-brouwer wants to merge 1 commit into
Draft
perf(client): skip rlp check if rlp clearly not large enough#3302jochem-brouwer wants to merge 1 commit into
jochem-brouwer wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #3302 +/- ##
================================================
Coverage 93.49% 93.49%
================================================
Files 624 624
Lines 37056 37056
Branches 3394 3394
================================================
Hits 34647 34647
Misses 1653 1653
Partials 756 756
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Not sure if I want this, but will dump this PR here otherwise I will forget. This calculates an upper bound on the RLP size of the block, and only if this upper bound could exceed the max we calculate the block RLP. This is an expensive operation which we only want to do if it is strictly necessary.
Will keep in draft because not sure if I want to push for this, it feels out of place, it gives nice speedups for the stateful filler though.
Related Issues or PRs
N/A.
Checklist
just static<type>(<area>): <title>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.Cute Animal Picture