refactor(tests): remove dead static-filler infrastructure - #3283
Merged
marioevz merged 5 commits intoAug 4, 2026
Conversation
Remove the static-filler stack, now dead after the legacy ethereum/tests fillers were ported to Python tests under tests/ported_static/: - Fill path: the static_filler.py plugin and the --fill-static-tests flag and plumbing (incl. the unconditional -p static_filler load in pytest-fill.ini and the FixtureCollector.fill_static_tests field). - Parser: specs/base_static.py and the specs/static_state/ package. - Migration tools: scripts/filler_to_python/, cli/fillerconvert/, cli/modify_static_test_gas_limits.py and their entry points. Relocate the two runtime helpers used by 339 ported tests (resolve_expect_post / resolve_expect_post_fork, plus the ForkSet / ForkConstraint / CMP / _match_index closure) into a new self-contained module specs/post_state_resolution.py, and codemod the imports. Also drop the now-dead yul_test and compile_yul_with markers (the yul fixture they keyed off lived only in static_filler.py). Removes the public exports execution_testing.specs.BaseStaticTest and execution_testing.specs.StateStaticTest (no in-repo consumers). To be merged after ethereum#2556 (ethereum/tests archival), whose parity tooling overlaps with the migration tools removed here.
7 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #3283 +/- ##
================================================
Coverage 93.49% 93.49%
================================================
Files 624 624
Lines 37056 37056
Branches 3394 3394
================================================
Hits 34647 34647
Misses 1653 1653
Partials 756 756
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
spencer-tb
force-pushed
the
remove-static-filler
branch
from
August 3, 2026 10:49
307e6ea to
f42f652
Compare
spencer-tb
marked this pull request as ready for review
August 3, 2026 11:38
2 tasks
marioevz
approved these changes
Aug 4, 2026
marioevz
left a comment
marioevz
left a comment
Member
There was a problem hiding this comment.
Nice! Thanks for this cleanup!
jochem-brouwer
added a commit
to jochem-brouwer/execution-specs
that referenced
this pull request
Aug 6, 2026
…r this base
Two things needed to make the cherry-picked filler optimizations work on
benchmarks/amsterdam.
1. ethereum-rlp rev pin. The stateful filler spends a large share of its time
decoding wide RLP lists -- block access lists in particular.
decode_joined_encodings probes each item's length by slicing the whole
remaining buffer, so decoding a list of N items copies O(N^2) bytes; bounding
that slice to the 9 bytes a length prefix can occupy measured 16x faster on
large BALs. ethereum-rlp is a PyPI dependency rather than a workspace member,
so the fix cannot travel as a commit here. Pin by rev, not version or branch:
the patched fork reports the same __version__ as upstream ("0.1.7"), so
resolving on version alone silently installs the unpatched wheel. Not yet
merged upstream (ethereum/ethereum-rlp master @ 2037ce5); drop the source and
raise the constraint once it lands.
2. The four TestStreamingWrites cases were written against forks/amsterdam,
where FixtureCollector's `fill_static_tests` argument had been removed by
"remove dead static-filler infrastructure" (ethereum#3283). benchmarks/amsterdam still
requires it, so they died with TypeError: missing 1 required keyword-only
argument. Pass fill_static_tests=False, matching every other construction in
the file. Test-only; the streaming collector itself is unaffected.
Verified: uv sync installs ethereum-rlp==0.1.7 from git+...@ab4e475f with
ITEM_LENGTH_PREFIX_MAX == 9, and 88 tests pass across test_collector.py,
test_forks.py and test_transactions.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ports #2950 by @leolara onto current
forks/amsterdam.With
tests/static/fully hand-ported totests/ported_static/, the static-filler stack is dead code. Removed here:static_filler.pypytest plugin, the--fill-static-testsflag, and all its plumbing (conditional plugin loading,FixtureCollector.fill_static_tests, the unconditional plugin registration inpytest-fill.ini).specs/base_static.pyand thespecs/static_state/package. The runtime post-state resolution helpers used by ported tests (resolve_expect_post/resolve_expect_post_fork) move totests/ported_static/post_state_resolution.py; ported test imports updated accordingly.scripts/filler_to_python/,cli/fillerconvert/,modify_static_test_gas_limits.py,verify_dynamic_addresses.sh.Also addresses @marioevz's review comments on #2950 in two follow-up commits:
fork is None→request.node.forkfallbacks (theprefixtures in the filler and execute plugins,node_id_for_entropy, andbase_test_parametrizer) are removed — static tests were the only unparametrized-fork items. Theprefixture hunk overlaps with feat(test-types): Fork-based State Commitment Property in Alloc #3279, which becomes a trivial rebase once this merges.post_state_resolution.pylives intests/ported_static/(its only consumer), imported astests.ported_static.post_state_resolutionfollowing thetests.benchmark.helperprecedent.A fourth commit removes the now-orphaned solc/Yul toolchain: the
plugins/solcpytest plugin (only ever loaded from the deleted--fill-static-testspath), theYul/Solc/YulCompilerfrontend intools_code(zero consumers in tests or framework; no CI job installs solc), thesolc_namefork API (its only reader was the Yul compiler), and leftover solc fixtures intools/tests/test_code.pywhose remaining tests are all Op-based.Related Issues or PRs
Supersedes #2950. Related: #2556, #3279.
Checklist
just static<type>(<area>): <title>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.Cute Animal Picture