chore(tooling): update write-test skill for automatic tx gas-limit - #2995
Merged
danceratopz merged 2 commits intoJun 18, 2026
Merged
Conversation
Agents kept adding the now-redundant `gas_limit=fork.transaction_gas_limit_cap()` boilerplate to tests. Document that `gas_limit` auto-fills when omitted (ethereum#2969), and is needed only for gas-sensitive tests.
4 tasks
raxhvl
reviewed
Jun 17, 2026
Apply review feedback: split the dense `gas_limit` bullet into Rule, Exception, and Anti-pattern bullets for scannability. Co-authored-by: raxhvl <10168946+raxhvl@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #2995 +/- ##
=====================================================
+ Coverage 81.28% 100.00% +18.71%
=====================================================
Files 620 1 -619
Lines 36641 1 -36640
Branches 3311 0 -3311
=====================================================
- Hits 29784 1 -29783
+ Misses 6335 0 -6335
+ Partials 522 0 -522
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
LouisTsai-Csie
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Since #2969 the transaction
gas_limitis optional and auto-fills when omitted, but thewrite-testskill never mentioned it, so agents kept adding the redundantgas_limit=fork.transaction_gas_limit_cap()boilerplate. This adds a minimalTransactionssection: omitgas_limitby default, set it explicitly only for gas-sensitive tests.🔗 Related Issues or PRs
Follows up on #2969 (automatic transaction gas-limit).
✅ Checklist
type(scope):.Cute Animal Picture