Skip to content

chore(tooling): update write-test skill for automatic tx gas-limit - #2995

Merged
danceratopz merged 2 commits into
ethereum:forks/amsterdamfrom
danceratopz:update-write-test-skill
Jun 18, 2026
Merged

chore(tooling): update write-test skill for automatic tx gas-limit#2995
danceratopz merged 2 commits into
ethereum:forks/amsterdamfrom
danceratopz:update-write-test-skill

Conversation

@danceratopz

@danceratopz danceratopz commented Jun 17, 2026

Copy link
Copy Markdown
Member

🗒️ Description

Since #2969 the transaction gas_limit is optional and auto-fills when omitted, but the write-test skill never mentioned it, so agents kept adding the redundant gas_limit=fork.transaction_gas_limit_cap() boilerplate. This adds a minimal Transactions section: omit gas_limit by default, set it explicitly only for gas-sensitive tests.

🔗 Related Issues or PRs

Follows up on #2969 (automatic transaction gas-limit).

✅ Checklist

  • All: Ran fast static checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    just lint-md
    just spellcheck
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

Cute Animal Picture

cute animal

Agents kept adding the now-redundant
`gas_limit=fork.transaction_gas_limit_cap()` boilerplate to tests.
Document that `gas_limit` auto-fills when omitted (ethereum#2969), and is needed
only for gas-sensitive tests.
Comment thread .claude/commands/write-test.md Outdated
Apply review feedback: split the dense `gas_limit` bullet into
Rule, Exception, and Anti-pattern bullets for scannability.

Co-authored-by: raxhvl <10168946+raxhvl@users.noreply.github.com>
@codecov

codecov Bot commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (e35d103) to head (453172d).
⚠️ Report is 8 commits behind head on forks/amsterdam.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           forks/amsterdam     #2995       +/-   ##
=====================================================
+ Coverage            81.28%   100.00%   +18.71%     
=====================================================
  Files                  620         1      -619     
  Lines                36641         1    -36640     
  Branches              3311         0     -3311     
=====================================================
- Hits                 29784         1    -29783     
+ Misses                6335         0     -6335     
+ Partials               522         0      -522     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@danceratopz danceratopz added C-chore Category: chore A-tooling Area: Improvements or changes to auxiliary tooling such as uv, ruff, mypy, ... labels Jun 17, 2026
@danceratopz
danceratopz merged commit fcd46ca into ethereum:forks/amsterdam Jun 18, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-tooling Area: Improvements or changes to auxiliary tooling such as uv, ruff, mypy, ... C-chore Category: chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants