Repository navigation
fix(fork): upstream sync goes red when a web file skips the React Compiler - #171
Merged
Merged
Conversation
…piler Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Pawl-Patrol
force-pushed
the
fix/web-react-compiler-guard
branch
from
October 30, 2026 08:51
bf4a805 to
789898f
Compare
Pawl-Patrol
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream's
apps/web/src/reactCompilerCoverage.test.tscatches web files that skip the React Compiler, which is what caused the React error pingdotgg#301 crash. Nothing onforkruns it:ci.ymldoesn't run here, and the sync'svp test relatednever selects it because it reads sources from disk instead of importing them.Fix
The upstream sync's
verifynow runs the coverage test explicitly, so a merge that makes a web file skip the compiler turns the sync red.The four compiler bailout fixes this PR first carried are dropped:
forkgot equivalent fixes in the meantime, so after rebasing only the guard is left.Verified
fork: 1405/1405 green.CommandPalette.tsxmakes the test fail, and the sync script'spipefailpasses that failure on to the step. The sync script itself was not run end to end.🤖 Generated with Claude Code