Update DataPlaneTable in admin view to use GQL instead of Supabase - #2067
Update DataPlaneTable in admin view to use GQL instead of Supabase#2067adrian-estuary wants to merge 15 commits into
Conversation
⚪ Code HealthNo change to the dead-code surface. 48 Unused files
66 Unused exports
30 Unused exported types
14 Unused exported enum members
5 Unused dependencies
3 Unused devDependencies
|
| <ToggleDataPlaneScope | ||
| scope={dataPlaneScope} | ||
| onChange={handleDataPlaneScopeChange} | ||
| /> |
There was a problem hiding this comment.
Updated the ToggleDataPlaneScope component to take in the scope and handle changes via a callback. There was some wonky interaction with it directly updating the context that caused a render loop.
c03a576 to
942ace8
Compare
|
left a few low-conviction comments so far - i'll get to the stuff that actually matters with fresh eyes tomorrow. |
53680d0 to
2a5bbf4
Compare
b6d1284 to
5227bb8
Compare
Update useDataPlanes.ts
- remove zustand store interaction - remove intl
- memoize data to fix render loop - remove toggle callback in favor of a set callback
5227bb8 to
140e0b0
Compare
cbc5372 to
6435566
Compare
6435566 to
f75e621
Compare
Issues
#2065
Changes
Requires landing control-plane-api: Add public/private filter option to DataPlanes query flow#3403 first, as it utilizes the newDone!publicfilter.Requires landing control-plane-api: Add tenant filter to dataPlanes query flow#3437, as it utilizes the new- Done!tenantfilter.DataPlanesTablecomponent to use the GQL hook.ToggleDataPlaneScopeto simplify scope selection.EnityTablecomponent.DataPlanesTable.Tests
Test plan
npm run formatnpm run typechecknpm run lintnpm run test(310 passed)Screenshots
Public data planes (default 1 local plane)

Private data planes (none in local)

Many data planes - paginated (seeded data)

Private data planes (only 1 page, no pagination controls show up)

Dialog

GQL query in network tab

If applicable - please include some screenshots of the new UI