Skip to content

control-plane-api: add filter to the liveSpecs GraphQL query and deprecate by #3383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
GregorShear wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

control-plane-api: add filter to the liveSpecs GraphQL query and deprecate by #3383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e3ab56
control-plane-api: add `filter` to `liveSpecs` and deprecate `by`
GregorShear Aug 19, 2026
5d6e49c
control-plane-api: bind the filter mode before the match so rustfmt h…
GregorShear Aug 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ...c7e4cac95ef04f4f4ec81d3459e01589395e.json → ...1ee0d5b77c19e41a2ae62d08c9084b20a492.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions ...c65c0ab03291a07ac0665026be9f115f10cb.json → ...f17e0291a72060e4f36a166da5269b40b0f3.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

35 changes: 35 additions & 0 deletions crates/agent/src/integration_tests/graphql/queries/live_specs_filter_catalog_name.graphql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
# The composable `filter` narrows results to the caller's authorized specs.
# Alice reads all of aliceCo/, so `startsWith` returns her whole shared
# subtree and `in` matches both of its entries. Bob reads aliceCo/shared/ via
# a role grant, so he sees the same shared subtree but the `in` entry for
# Alice's private capture is dropped rather than erroring.
query LiveSpecsFilterCatalogName {
startsWith: liveSpecs(
filter: { catalogName: { startsWith: "aliceCo/shared/" } }
) {
edges {
node {
catalogName
userCapability
}
}
}
inSet: liveSpecs(
filter: {
catalogName: {
in: [
"aliceCo/shared/a"
"aliceCo/private/capture"
"bobCo/does-not-exist"
]
}
}
) {
edges {
node {
catalogName
userCapability
}
}
}
}
62 changes: 62 additions & 0 deletions ...ots/agent__integration_tests__graphql__queries__alice-live_specs_filter_catalog_name.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
---
source: crates/agent/src/integration_tests/graphql/queries/mod.rs
expression: alice_result
---
{
"inSet": {
"edges": [
{
"node": {
"catalogName": "aliceCo/private/capture",
"userCapability": "admin"
}
},
{
"node": {
"catalogName": "aliceCo/shared/a",
"userCapability": "admin"
}
}
]
},
"startsWith": {
"edges": [
{
"node": {
"catalogName": "aliceCo/shared/a",
"userCapability": "admin"
}
},
{
"node": {
"catalogName": "aliceCo/shared/b",
"userCapability": "admin"
}
},
{
"node": {
"catalogName": "aliceCo/shared/c",
"userCapability": "admin"
}
},
{
"node": {
"catalogName": "aliceCo/shared/capture",
"userCapability": "admin"
}
},
{
"node": {
"catalogName": "aliceCo/shared/disabled",
"userCapability": "admin"
}
},
{
"node": {
"catalogName": "aliceCo/shared/materialize",
"userCapability": "admin"
}
}
]
}
}
2 changes: 1 addition & 1 deletion ...agent__integration_tests__graphql__queries__alice-live_specs_missing_name_and_prefix.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
source: crates/agent/src/integration_tests/graphql/queries/mod.rs
expression: alice_result
---
"GraphQL query failed with error: GraphQL errors: [ServerError { message: \"must provide at least one of `names` or `prefix`\", locations: [Pos(2:5)], path: [Field(\"liveSpecs\")], extensions: None }]"
"GraphQL query failed with error: GraphQL errors: [ServerError { message: \"must provide at least one of `names` or `prefix`, or omit `by` entirely\", locations: [Pos(2:5)], path: [Field(\"liveSpecs\")], extensions: None }]"
56 changes: 56 additions & 0 deletions ...shots/agent__integration_tests__graphql__queries__bob-live_specs_filter_catalog_name.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
---
source: crates/agent/src/integration_tests/graphql/queries/mod.rs
expression: bob_result
---
{
"inSet": {
"edges": [
{
"node": {
"catalogName": "aliceCo/shared/a",
"userCapability": "read"
}
}
]
},
"startsWith": {
"edges": [
{
"node": {
"catalogName": "aliceCo/shared/a",
"userCapability": "read"
}
},
{
"node": {
"catalogName": "aliceCo/shared/b",
"userCapability": "read"
}
},
{
"node": {
"catalogName": "aliceCo/shared/c",
"userCapability": "read"
}
},
{
"node": {
"catalogName": "aliceCo/shared/capture",
"userCapability": "read"
}
},
{
"node": {
"catalogName": "aliceCo/shared/disabled",
"userCapability": "read"
}
},
{
"node": {
"catalogName": "aliceCo/shared/materialize",
"userCapability": "read"
}
}
]
}
}
2 changes: 1 addition & 1 deletion ...s/agent__integration_tests__graphql__queries__bob-live_specs_missing_name_and_prefix.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
source: crates/agent/src/integration_tests/graphql/queries/mod.rs
expression: bob_result
---
"GraphQL query failed with error: GraphQL errors: [ServerError { message: \"must provide at least one of `names` or `prefix`\", locations: [Pos(2:5)], path: [Field(\"liveSpecs\")], extensions: None }]"
"GraphQL query failed with error: GraphQL errors: [ServerError { message: \"must provide at least one of `names` or `prefix`, or omit `by` entirely\", locations: [Pos(2:5)], path: [Field(\"liveSpecs\")], extensions: None }]"
Loading
Loading