Removed annoying deuplicates from pacakge italian-accented-words, bumped version - #237
Conversation
|
Looks straightforward to merge. No potentially malicious code. I'll run the CI and let Copilot check it. |
There was a problem hiding this comment.
Pull request overview
This PR introduces version 0.1.2 of the italian-accented-words package, aligning the package metadata and documentation with the updated (deduplicated) substitution list shipped in this version.
Changes:
- Added a README describing what the package contains and its data provenance/licensing.
- Added a
_manifest.ymldefining package metadata (name/title/version/tags/homepage).
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/italian-accented-words/0.1.2/README.md | Adds package description and licensing/provenance notes. |
| packages/italian-accented-words/0.1.2/_manifest.yml | Adds package metadata for the 0.1.2 release. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| This package contains a list of accented Italian words substitutions. | ||
| It only contains words which don't have a non-accented corresponding word in the Italian dictionary. |
| It only contains words which don't have a non-accented corresponding word in the Italian dictionary. | ||
| For example 'scherzò' is not present since 'scherzo' is also a valid Italian word, while 'città' is present because 'citta' is not an Italian word. | ||
|
|
||
| Some words are extracted from [verb-data](https://github.com/ian-hamlin/verb-data) which is distributed under [CC BY-SA 3.0 licence](https://creativecommons.org/licenses/by-sa/3.0/). No newline at end of file |
| @@ -0,0 +1,7 @@ | |||
| author: Alessandro Cantini | |||
| description: List of substitutions of Italian accented words | |||
|
I think Copilot won't read the long package.yml file.. You would be better off comparing the two files with your IDE, this should demonstrate only removals have been made. |
|
Yes, I don't think Copilot had access to the original anyway, and the way Federico set up the versioning makes it difficult to make direct comparisons in GitHub. I'm exploring the Compare facility in VSCodium - thanks for the suggestion, but I'm happy to merge. |
Was getting many choices for duplicate replacements, therefore removed all annoying duplicates.