Add italian-cap package - #236
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a new Espanso hub package (italian-cap) that expands Italian CAP (postal codes) into CAP + comune via per-CAP triggers.
Changes:
- Added package README documenting installation, usage, and how duplicate CAPs are resolved to a single comune.
- Added MIT license for the package.
- Added hub manifest metadata (
_manifest.yml) for listing and discovery.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/italian-cap/0.1.0/README.md | Documents package purpose, installation, usage, and data resolution rules. |
| packages/italian-cap/0.1.0/LICENSE | Adds MIT licensing information for the package. |
| packages/italian-cap/0.1.0/_manifest.yml | Provides hub metadata (name/title/description/version/author/tags) for the package. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
smeech
left a comment
There was a problem hiding this comment.
A simple package of trigger/replace pairs. No script, shell or potentially malicious code. A couple of changes to make, please.
I'll run Copilot and the automated checks.
ff6e6fd to
43a02bb
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (2)
packages/italian-cap/0.1.0/_manifest.yml:7
- The
homepagepoints to a branch-specific URL (.../tree/add-italian-cap) and appears to have a typo in the GitHub username (blacne0nvsblackne0n). After merging, branch links may disappear and users will be sent to a 404; consider updating this to a stable URL (e.g., default branch or a dedicated repository page for the package).
homepage: "https://github.com/blacne0n/hub/tree/add-italian-cap"
packages/italian-cap/0.1.0/README.md:22
- The README mentions that triggers are generated from an “ISTAT-derived” list, but it doesn’t include a source link or any licensing/attribution details for that dataset. Adding the specific dataset URL and its license/terms would make redistribution terms clear for downstream users.
## Data
Triggers are generated from the ISTAT-derived list of
Italian comuni with their CAP.
43a02bb to
6ccccdc
Compare
Add italian-cap package which converts italian CAP (CAP code) to CAP + City name.