Repository navigation
ecad: rename a part symbol file whose name Windows cannot check out (fixes Build and Package Main) - #130
Merged
Conversation
`ecad/elec/src/parts/Ckmtw_B_2100S02P_A110/210S-1*2PL=11.6MMGold-platedblack.kicad_sym` contains `*`, which is not a legal path character on Windows. Every run of "Build and Package Main" since the ecad update has failed in the package job: its action checks the repository out on windows-latest, and git aborts with `error: invalid path 'ecad/elec/src/parts/.../210S-1*2PL=...kicad_sym'`. Rename it to `210S-1x2PL_11.6MMGold-platedblack.kicad_sym` (also dropping `=`) and update the symbol names inside it and the `symbol=` reference in the part's `.ato` trait. It is the only tracked path with a Windows-illegal character. `ato build -b box-emu-base` (the one target that uses the part) still passes with the offline components stand-in. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AWhoGwibqcKDhcG17mjVT1
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The filename, internal symbol identifiers, and consuming reference are consistent, with no stale references remaining.
0 open findings
What changed in this PR
Renames the KiCad symbol to a Windows-compatible filename, restoring package checkout on Windows.
Changes:
- Replaces invalid
*and=filename characters. - Updates internal symbol names and the atopile reference.
| File | Description |
|---|---|
Ckmtw_B_2100S02P_A110.ato |
References the renamed symbol file. |
210S-1x2PL_11.6MMGold-platedblack.kicad_sym |
Renames the symbol and its unit consistently. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
Proof before merge: dispatched "Build and Package Main" on this branch — https://github.com/esp-cpp/esp-box-emu/actions/runs/38415975471 — build ✓ and all three package jobs (windows-latest, macos-latest, ubuntu-latest) ✓. The same workflow has failed on every push to main since the ecad update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Build and Package Main" has failed on every push to
mainsince the ecad update. Thebuildjob is fine; thepackagejob fails onwindows-latestbefore doing anything, because its action checks the repository out and the checkout refuses one path:*is not a legal filename character on Windows. This is the only tracked path containing one of* ? : " < > | \(scanned the full tracked-file list).Fix: rename the KiCad symbol file to
210S-1x2PL_11.6MMGold-platedblack.kicad_sym(also dropping=), rename the symbol units inside it to match, and update thesymbol=reference in the part'sis_atomic_parttrait. The part'sValueproperty keeps the manufacturer's original string.Verified:
ato build -b box-emu-base(the one target that uses this part) passes with the offline components stand-in — PCB update, BOM, pinout all succeed; the only reported error is the unrelated LCSC datasheet download returning HTML. The checked-in layout is untouched (the local build's serialization churn was reverted, per the ecad CI notes).🤖 Generated with Claude Code
https://claude.ai/code/session_01AWhoGwibqcKDhcG17mjVT1