CI を統合して .NET 10 に更新 - #12
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4a6a1ec847
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a5655efc2c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| permissions: | ||
| contents: write |
There was a problem hiding this comment.
Limit contents: write to a separate tag-only release job rather than granting it to the entire build job. For same-repository pull requests, this workflow checks out and executes the PR's MSBuild/workflow code with a write-capable GITHUB_TOKEN, so a contributor or compromised build step can use ${{ github.token }} to alter tags, releases, or repository contents even though only the final release command needs write access.
Useful? React with 👍 / 👎.
| </Reference> | ||
| </ItemGroup> | ||
| <ItemGroup Condition="'$(FrooxEnginePresent)'!='true'"> | ||
| <PackageReference Include="Resonite.GameLibs" /> |
There was a problem hiding this comment.
Avoid conditionally removing this package based on whether a local Resonite installation contains FrooxEngine.dll. The committed lock file records Resonite.GameLibs as a direct dependency, but on the normal development path where Resonite is installed this condition evaluates false; dotnet restore --locked-mode then rejects the mismatched graph, while an ordinary restore rewrites the tracked lock file. This makes the newly enabled package lock nonportable between CI's fallback environment and developers' installed-game environment.
Useful? React with 👍 / 👎.
1 participant
概要
ci.ymlに CI/release workflow を統合ローカル検証
dotnet restore .\ViveStreamingFaceTrackingForResonite.sln -p:ResonitePath="C:\Program Files (x86)\Steam\steamapps\common\Resonite\"dotnet build .\ViveStreamingFaceTrackingForResonite.sln -c Release --no-restore -p:ResonitePath="C:\Program Files (x86)\Steam\steamapps\common\Resonite\"