Add reusable static checks and editor/runtime cleanup for alpha - #40
Add reusable static checks and editor/runtime cleanup for alpha#40esnya wants to merge 2 commits into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4c4e781ad5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| private void OnEnable() | ||
| { | ||
| Load((MultiTextLoader)target, false); | ||
| } |
There was a problem hiding this comment.
Loading is now triggered only from the custom inspector's OnEnable, which runs for the currently inspected component, not for every MultiTextLoader in the scene. This removes the previous Start()-time refresh behavior in editor play mode, so entering Play/Build & Test without manually selecting each loader can leave TMP_Text content stale and make local validation inconsistent with what the build callback later applies.
Useful? React with 👍 / 👎.
| "name": "com.vrchat.udonsharp", | ||
| "expression": "1.0.0", | ||
| "define": "INARI_UDON_HAS_UDONSHARP_EDITOR" |
There was a problem hiding this comment.
The editor assembly now depends on a symbol generated from com.vrchat.udonsharp, so in environments where only com.vrchat.worlds is installed (the package declared in this repo), INARI_UDON_HAS_UDONSHARP_EDITOR is never defined and the entire InariUdon.Editor assembly is excluded. That disables all custom inspectors and build callbacks in this package, including MultiTextLoaderBuildCallback.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 277f90037d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
|
|
||
| InariUdonEditorUtility.RecordAndDirty("ScaledMultiFollower Sync Now", undoTargets, () => follower.EditorSyncNow()); | ||
| InariUdonEditorUtility.RecordAndDirty("ScaledMultiFollower Sync Now", undoTargets, () => SyncNow(follower)); |
There was a problem hiding this comment.
The inspector now calls the local SyncNow helper instead of ScaledMultiFollower.EditorSyncNow(), which means the Sync Now button no longer executes the runtime-style Start()+_Trigger() path that handles options like copyActive, deactivateExcessiveTargets, toggleTargetColliders, and freezeTargetWhileSoruceHeld (see Transform/ScaledMultiFollower.cs). In scenes that rely on those flags, pressing Sync Now now updates only positions/rotations and leaves activation/collider state stale, so editor validation can diverge from actual runtime behavior.
Useful? React with 👍 / 👎.
1 participant
Summary\n- add reusable static checks and udonsharp-lint workflow for the package\n- split editor-only helpers and build callbacks out of runtime code\n- keep package behavior aligned with current Unity/VRChat environment\n\n## Validation\n- bash scripts/run-static-checks.sh\n- bash scripts/run-local-checks.sh\n- GitHub Actions: Check workflow (static-checks + udonsharp-lint)