Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! On Solaris, the
BYTE_ORDER,BIG_ENDIAN, orLITTLE_ENDIANmacros are not defined, which makes e.g.#if BYTE_ORDER == BIG_ENDIANnot work as expected.This PR defines all three those based on Solaris specific
_BIG_ENDIANand_LITTLE_ENDIANmacros.I found this on Oracle Solaris when cross testing between SPARC and Intel systems (each having different endianness). Since I am unsure whether e.g. Illumos or other OpenSolaris forks also lack these definitions, I added the
if !definedguards just to be sure I don't break them.This was tested with iperf3 3.22.