Support unlimited number of parallel streams - #2084
Open
davidBar-On wants to merge 1 commit into
Open
davidBar-On wants to merge 1 commit into
davidBar-On wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version of iperf3 (or development branch, such as
masteror3.1-STABLE) to which this pull request applies:master 3.22
Issues fixed (if any): Cannot use more than 128 parallel streams #2079
Brief description of code changes (suitable for use as a commit message):
Support practically unlimited number of parallel streams by replacing
select()bypoll(). Assumption is thatselect()was required for the single-thread version of iperf3 to monitor all the parallel streams. With the multi-thread version this is not required as the main thread monitors only the control related streams, and each of the worker threads monitor only one stream.The number of parallel streams (
--parallel) is still limited, to 32K, just for checking input error, assuming that this is much more than what will be required practically.The
--paralleloption is now supported also for the server, to allow specifying a limit to the number of streams the client can set. The default is 128 for backward compatibility.