Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version of iperf3:
master
Issues fixed:
Addresses the no-omit UDP loss reporting case related to UDP loss figures incorrect and self-inconsistent against pre-3.13 peers (omitted_* substitution) #2055.
Follow-up to Fix backward compatibility issue of client incorrectly print 0 UDP packets loss #1988; does not address all scenarios in UDP loss figures incorrect and self-inconsistent against pre-3.13 peers (omitted_* substitution) #2055.
Brief description of code changes:
When an older peer does not return omitted statistics, result parsing
can assign the entire loss count to omitted_cnt_error. Per-stream text
output handles the no-omit case separately, but SUM subtracts this
value and incorrectly reports zero losses.
Set omitted_cnt_error to zero when no omit period is configured.
Preserve existing compatibility handling for tests with an omit period.
Add regression tests for result exchange and reporting. Before the fix,
four streams with 100 total lost packets incorrectly produce a zero-loss
SUM.
Validation:
legacy/current result formats, and omit-period compatibility.
and omit-period cases.
an actual older server binary.