fix: remap locations for unused disable directives#669
Open
xbinaryx wants to merge 3 commits into
Open
Conversation
DMartens
reviewed
Jun 5, 2026
DMartens
reviewed
Jun 5, 2026
DMartens
reviewed
Jun 5, 2026
DMartens
reviewed
Jun 5, 2026
lumirlumir
requested changes
Jun 7, 2026
DMartens
reviewed
Jun 10, 2026
DMartens
reviewed
Jun 10, 2026
DMartens
approved these changes
Jun 12, 2026
DMartens
left a comment
Contributor
There was a problem hiding this comment.
Changes LGTM, thanks. Leaving open for lumir.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
AI acknowledgment
What is the purpose of this pull request?
This PR enables the reporting of unused directive comments (such as
<!-- eslint-disable no-console -->) in Markdown files. WhenreportUnusedDisableDirectivesis enabled, ESLint flags these configuration comments if they do not actively suppress any rules. Because the Markdown processor prepends these comments to the generated code, they fall outside the block boundaries. Previously, the processor returnednullfor these messages, causing ESLint to skip them. This PR intercepts unused directive reports and correctly maps them back to their absolute line, column, and autofix offsets in the Markdown source.What changes did you make? (Give an overview)
commentsfrom an array of strings to objects that track original source locationposition.Related Issues
Fixes #115
Is there anything you'd like reviewers to focus on?