test: test with ESLint instead of CLIEngine when available#198
Merged
Conversation
Member
|
Tests are failing |
MichaelDeBoey
force-pushed
the
patch-3
branch
from
a6f6800 to
13852b3
Compare
btmills
reviewed
Nov 28, 2021
MichaelDeBoey
force-pushed
the
patch-3
branch
2 times, most recently
from
df96abf to
95ad277
Compare
btmills
suggested changes
Nov 28, 2021
btmills
left a comment
btmills
left a comment
Member
There was a problem hiding this comment.
Ideally we're one typo fix away from all tests passing 🤞 If that's true, LGTM once that change is made!
MichaelDeBoey
force-pushed
the
patch-3
branch
from
95ad277 to
e89b989
Compare
Contributor
Author
|
@btmills All tests are green now 🥳🎉 |
btmills
approved these changes
Nov 30, 2021
btmills
left a comment
btmills
left a comment
Member
There was a problem hiding this comment.
Woohoo, no implementation changes needed to work with the ESLint API! Thanks for proving that in these tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As asked by @btmills in #195 (comment)