fix(eks): AWS provider v6 compatibility; feat(vpc): route table outputs - #315
Merged
Merged
Conversation
…e outputs - eks: resolve_conflicts was removed in hashicorp/aws v6 (deprecated in v5); replaced with resolve_conflicts_on_create/on_update (available since v5.0), so the module now validates under both v5 and v6. - vpc: expose public/private route table ids so consumers can attach gateway VPC endpoints (S3/DynamoDB) without data-source workarounds.
…flict-resolution args
Contributor
Author
|
Adicionado |
carloslima-escale
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivação
O módulo
eksnão valida sob o provider AWS v6: usaresolve_conflictsnosaws_eks_addon(kube-proxy e CoreDNS), argumento removido no v6 (depreciado desde o v5). Qualquer consumidor comaws ~> 6.xrecebe:Encontrado ao consumir o módulo no projeto data-platform (contas novas, provider v6).
Mudanças
1.
eks: compatibilidade com provider v6 (fix)resolve_conflicts→resolve_conflicts_on_create+resolve_conflicts_on_update(ambos"OVERWRITE", preservando o comportamento). Os argumentos novos existem desde o provider v5.0, então o módulo passa a validar em v5 e v6 — nenhum consumidor atual é afetado.2.
vpc: outputs de route tables (aditivo)O módulo cria as route tables mas não as exporta — consumidores que precisam anexar gateway VPC endpoints (S3/DynamoDB) hoje recorrem a
data "aws_route_tables"como workaround. Adicionapublic_route_table_ideprivate_route_table_ids(map por chave de subnet). Mudança puramente aditiva.Validação
terraform validatedemodules/ekssob provider v6: falhava antes, Success depoisterraform validatedemodules/vpcsob provider v6: Successterraform fmtlimpoFora do escopo (registrado para follow-up, se fizer sentido)
Os defaults de
eks_version/addons apontam para a era 1.21 (2021, fora de suporte). Não alterados aqui de propósito: mudar default pode impactar consumidor existente que dependa dele (upgrade de cluster é one-way). Sugestão futura: tornar as versões de addonnullable(omitir = AWS escolhe a compatível com o cluster).Relacionado: #314 (vpc
nat_strategy) — se ambos mergearem, uma tag de release (ex.:v1.1.0) cobriria os dois e permitiria consumo pinado por tag.