fix: make result extrema scale safe - #98
Open
petergstfsn wants to merge 1 commit into
Open
Conversation
Contributor
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
opencae | eb0b12d | Aug 28 2026, 07:27 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
finiteExtremareduction for ordinary arrays, sparse arrays, typed arrays, and projected values without input copies or argument spreadingBROWSER_SOLVE_LIMITSthe explicit product-limit authority and distinguish the approximately 100k validation benchmark from the guarded 150k-DOF ceilingPublic contracts and review flags
@opencae/corenow exportsfiniteExtremaandFiniteExtrema.nullfor empty/all-nonfinite inputs, and treats ordinary/sparse/typed arrays consistently. Existing result-field fallbacks retain a finite0..0range for empty fields.@opencae/mesh-intakegains one existing workspace dependency on the lightweight@opencae/solve-pipeline/limitsentry point. No third-party dependency was added.Verification
pnpm install --frozen-lockfile— passedgit diff --check— passed; the repository has no formatter command or root lint jobpnpm --filter "./packages/*" --if-present lint— passed (the five package lint scripts are typecheck aliases)pnpm --filter "./packages/*" --if-present test— passed: 259 testsnode scripts/verify-cloudflare-config.mjs— passedpnpm typecheck— passedpnpm test— passed: 153 files, 1,590 testspnpm verify:step-selection-browser— passed in real Chrome for 1 mm, 25 mm, and 500 mm fixtures; detailed/balanced face IDs and fingerprints matched with no console or page errorspnpm build:cloudflare— passedpnpm --filter @opencae/web check:bundle— passed: initial JS 63,822/179,200 bytes gzip; total JS 1,343,404/1,536,000; largest lazy gzip 141,618/307,200; largest lazy raw 445,787/512,000; precache 24,580,590/27,262,976pnpm verify:perf— passed its production build and local HTTP/startup checks (402 ms startup); its optional Playwright browser probe was not configured and was skippednode scripts/verify-100k-solve.mjs— attempted with host Chrome access, but timed out waiting for the Chrome solve-benchmark result after approximately nine minutes; the serial WebKit leg did not start. This run supplies no new cross-browser or 150k performance certification.Assumptions
BROWSER_SOLVE_LIMITSis authoritative because current production preflight and worker orchestration import it, and no contrary code authority was found.No deployment, production service, migration, secret, or infrastructure operation was performed.