Skip to content

feat: improve stack safety, layout fidelity, and golden testing - #149

Merged
erweixin merged 14 commits into
mainfrom
improve
Jul 28, 2026
Merged

feat: improve stack safety, layout fidelity, and golden testing#149
erweixin merged 14 commits into
mainfrom
improve

Conversation

@erweixin

Copy link
Copy Markdown
Owner

No description provided.

erweixin added 14 commits July 26, 2026 02:45
…ages, and example inputs for improved user experience
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 27, 2026

Copy link
Copy Markdown

Deploying ratex with  Cloudflare Pages  Cloudflare Pages

Latest commit: 25f6750
Status: ✅  Deploy successful!
Preview URL: https://811b8e08.ratex.pages.dev
Branch Preview URL: https://improve.ratex.pages.dev

View logs

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 25f67506c9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 211 to +213
mask = get_ink_mask(img)
if not np.any(mask):
return img[:10, :10] # fallback: tiny empty
return img[:10, :10]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Reject one-sided blank renders before shape scoring

When RaTeX emits an all-white PNG for a newly added, roughly square formula, this substitutes a 10×10 white crop; the later metric can then award up to 0.4 from aspect and width similarity alone, exceeding the default 0.30 pass threshold despite rendering no ink. Because the PNG is considered scored, coverage checks also accept it, and a new formula has no prior per-case baseline to catch the failure. Detect whether exactly one image has no ink and assign it a failing score, while handling intentionally blank reference/output pairs separately.

Useful? React with 👍 / 👎.

@erweixin
erweixin merged commit ffe551e into main Jul 28, 2026
8 checks passed
@erweixin
erweixin deleted the improve branch July 28, 2026 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant