Add SVE2 optimizations of ImagePngSaver - #912
Merged
Merged
Conversation
Implement SVE2 PNG filter encoding, Adler-32, and zlib match counting for ImagePngSaver, wire it into ImageSaveToMemory, extend save tests for unaligned PNG sizes, and note the change in release 7.2.165. Co-authored-by: igor.ermolaev <igor.ermolaev@altezza.org>
Remove extra tiny PNG cases so Base/SVE2 performance rows are not mixed with 3x4 and other unaligned micro-benchmarks. Co-authored-by: igor.ermolaev <igor.ermolaev@altezza.org>
ermig1979
marked this pull request as ready for review
August 24, 2026 15:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add SVE2 optimizations of
ImagePngSaverfor ARM/ARM64, used byImageSaveToMemoryand checked byTest::ImageSaveToMemoryAutoTest.Changes
src/Simd/SimdSve2ImageSavePng.cppwith SVE2 PNG filter encoding (EncodeLine0–EncodeLine6), vectorized Adler-32, zlib match counting, and zlib compression.Sve2::ImagePngSaverinherits fromNeon::ImagePngSaverand uses SVE2BgrToRgb/BgraToRgbaconverters.Sve2::ImagePngSaverintoSve2::ImageSaveToMemory.Test::ImageSaveToMemoryAutoTestalready comparesSve2::ImageSaveToMemorywith the public API, including PNG.SimdSve2ImageSavePng.cpp(and related headers) toprj/vs2022/Sve2.vcxprojandSve2.vcxproj.filters.docs/2026.htmlfor release 7.2.165.Test plan
./Test "-r=.." -fi=ImageSaveToMemory -tt=1 -ts=1.SimdSve2ImageSavePng.cppwith-march=armv9-a+sve+sve2+i8mm+bf16.Testworkflow onubuntu-24.04-armwith SVE2 (build_and_test_arm64).