Add C++ wrapper Simd::SynetGatherElements - #909
Merged
Conversation
Add a C++ analogue of Synet::GatherElements in SimdSynet.hpp, a CheckCpp test, Doxygen notes for the C API, and release 7.2.165 documentation. Co-authored-by: igor.ermolaev <igor.ermolaev@altezza.org>
ermig1979
marked this pull request as ready for review
August 24, 2026 13:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a public C++ analogue of
Synet::GatherElements(src/Synet/Utils/Gather.hin ermig1979/Synet) to the Simd Library.Simd::SynetGatherElementsinsrc/Simd/SimdSynet.hppwrappingSimdSynetGatherElementsInit/SimdSynetGatherElementsSetIndex/SimdSynetGatherElementsInternalBufferSize/SimdSynetGatherElementsForward/SimdRelease.cpp_synet) and C API notes pointing to the wrapper.TestSynetGatherElements()insrc/Test/TestCheckCpp.cppcompares the wrapper with the C API.docs/2026.html(release 7.2.165) updated.src/Simd/SimdSynet.hppis already listed inprj/vs2022/Simd.vcxprojandprj/vs2022/Simd.vcxproj.filters(added withSimd::SynetAdd16b).Testing
g++,SIMD_SHARED=ON) of the library andTest../Test "-r=.." -cc=1 -fi=SynetGatherElements -tt=1 -ts=1: CheckCpp (includingTestSynetGatherElements) and SynetGatherElements C API tests finished successfully.Simd::SynetGatherElements::Enable()is true; wrapper output matches the C API and expected gather resultdst=[0, 2, 1, 7, 5, 4]forsrc=[0..7],idx=[0,2,1,3,1,0],outer={2},srcCount=4,inner=1,idxCount=3.