Refactor Simd::FillFrame to use Simd::Fill - #906
Merged
Conversation
Implement the C++ wrapper with four Simd::Fill calls on View regions instead of forwarding to SimdFillFrame. Update docs and compare the wrapper with the C API in FillFrame tests. Co-authored-by: igor.ermolaev <igor.ermolaev@altezza.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Simd::FillFramewas a thin C++ wrapper aroundSimdFillFrame. It now fills the four outer regions withSimd::FillonView::Regionviews:[0, width) x [0, frame.top)[0, width) x [frame.bottom, height)[0, frame.left) x [frame.top, frame.bottom)[frame.right, width) x [frame.top, frame.bottom)The C API
SimdFillFrame/Base::FillFrameis unchanged.Test plan
g++, Release,SIMD_SHARED=ON)../Test "-r=.." -fi=FillFrame -tt=1 -ts=1— ALL TESTS ARE FINISHED SUCCESSFULLY (compares Base vsSimdFillFrameand the C++ wrapper vsSimdFillFrame).SimdFillFrameand a pixel oracle.Test / build_and_test_arm64on this PR: success.FillFrame official test report
To show artifacts inline, enable in settings.