Add touch gesture support for emery/flint/gabbro#2
Draft
brooks2564 wants to merge 2 commits into
Draft
Conversation
Swipe up/down scrolls through forecast hours; tap cycles to the next data page. Guarded by PBL_TOUCHSCREEN so non-touch platforms are unaffected. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The previous implementation called click handlers with NULL recognizer, causing a crash on click_recognizer_is_repeating(). Navigation logic is now in prv_navigate_up/down/page helpers called by both click and touch handlers. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Owner
|
Thanks for taking the time to make a pull request! There are some issues as is, which will need to be fixed before I would merge this:
Also, if you want to test the app locally, but don't want to bother with setting up a WeatherKit key, you can go to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PBL_TOUCHSCREENso non-touch platforms (aplite, basalt, chalk, diorite) are completely unaffectedImplementation
Navigation logic was extracted into
prv_navigate_up(),prv_navigate_down(), andprv_navigate_page()helpers shared by both the button click handlers and the new touch handler.touch_service_subscribeis called inprv_window_loadand unsubscribed inprv_window_unload.Test plan
🤖 Generated with Claude Code