checkpoint 1 - #6
Conversation
|
I know this doesn't exactly work I tried my best |
| function checkForWin() { | ||
| // Your code here | ||
| const isLegal = (startStack, endStack) => { | ||
| const SSLastNum = stacks[startStack][stacks[startStack].length-1]; |
There was a problem hiding this comment.
These variable names should start with a lowercase letter. The convention is upper case would signify a class.
| const SSLastNum = stacks[startStack][stacks[startStack].length-1]; | ||
| const ESLastnum = stacks[endStack][stacks[endStack].length-1]; | ||
| if (ESLastnum > SSLastNum) { | ||
| return true; |
There was a problem hiding this comment.
this can be simplified, just return the evalutation
|
|
||
| } | ||
| const checkForWin = () => { | ||
| let checkWin = false; |
There was a problem hiding this comment.
This function would always return a truthy value ('You win' or 'You suck') so your parent function that checks for the return would always reset the stack. What would be better is if you just returned a truthy or falsy value and have the parent function return the message.
| const checkForWin = () => { | ||
| let checkWin = false; | ||
| const solution = [4, 3, 2, 1]; | ||
| for (index = 0; index < 4; index++) { |
There was a problem hiding this comment.
this loop is unnecessary, just check if stack b or c has a length of 4
| function towersOfHanoi(startStack, endStack) { | ||
| // Your code here | ||
| const resetStack = () => { | ||
| let stacks = { |
There was a problem hiding this comment.
you shouldn't redeclare here, stacks were defined at line 22
| if (stacks[endStack].length == 0) { | ||
| movePiece(startStack, endStack); | ||
| } else { | ||
| if (isLegal(startStack, endStack)) { |
2 participants
Checkpoint Rubric
This is the rubric that your instructor will use to grade your checkpoints. Please do not edit.
Checkpoint 1
Checkpoint 2
Checkpoint 3