Repository navigation
Web pages say MCP field names and raw collector counts in words (#6649) #6670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
008dbcd
Web pages say MCP field names and raw collector counts in words (#6649)
erikdarlingdata 72c3a82
Merge remote-tracking branch 'origin/dev' into fix/6670-r1
erikdarlingdata ba5ae55
Fix the round-1 review findings on the web plain-text names change (#…
erikdarlingdata File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These four sentences are copied into the test rather than read from the service, so the test cannot fail the way this fix actually dies. Three of the rules added in
plain-text.jsare whole-sentence literal matches against strings owned by C#:DarlingMcpQueryStoreRegressionTools.cs:111(andLite/Mcp/McpQueryTools.cs:642) — the baseline tailDarlingMcpQueryStoreClutterTools.cs:408/:409— the two clerk notesDarlingMcpQueryStoreClutterTools.cs:182,DarlingMcpFinOpsTools.IndexAnalysis.cs:215,PerformanceMonitor.Common/CollectorRunFacts.cs:80—(see databases_left_out)(this one is a generic suffix strip, so it is the safe one)Reword any of those C# sentences by one character and the JS
replacestops matching, the field name is back on the page, and all four assertions here still pass, because they are asserting against this file's own copy of the old wording. REVIEW-TRAPS: "Two copies of one definition pinned EQUAL to each other fail only after BOTH have drifted (#3684). Alias, do not copy."This file already knows the better way twice:
TheEngineGateSentence_NamesAzureSqlDatabase_WhenThatIsTheEngine(:429) andTheTempDbFileIoAzureAnswer_IsNotCollected_AndBecomesTheAzureLine(:440) build their input by calling the producer (CollectorEngineCapability.NotCollectedMessage,DarlingEngineCapability.TempDbFileIoNotCollectedStatus) and then assert the page's words. Lifting these sentences toconston their tool classes and feeding them in the same way makes the drift fail here instead of shipping silently.