Repository navigation
Leave the monitor's own statement and dropped databases out of Query Store regressions (#6654) #6665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Leave the monitor's own statement and dropped databases out of Query Store regressions (#6654) #6665
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
24744b9
Leave the monitor's own statement and dropped databases out of the Qu…
erikdarlingdata 0494484
Act on the round-1 review of the regressions marker/dropped-database …
erikdarlingdata f47eba9
Merge remote-tracking branch 'origin/dev' into fix/6665-r1
erikdarlingdata 68a099d
Hide the monitor's own Query Store statement from every ranked reader…
erikdarlingdata 326ff65
Merge remote-tracking branch 'origin/dev' into fix/6665-merge
erikdarlingdata File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fixture carries inline text, which is the one shape a live Darling store does not produce — so the arm that fires in production is the one this does not test.
WriteAsyncsetsQueryStoreCollector.Row.QueryText, so the marker lands inquery_store_stats.query_textand the new predicate finds it in thef.query_text_samplefallback. On a real Darling store that column is null for every row collected since the separate-fetch cutover (QueryStoreCollector.cs:768-770), and the marker lives only inquery_store_text— theSELECT x.query_sql_text …arm (QueryStoreRegressionBaseline.cs:580-583). Nothing here puts a row inquery_store_text, so a mistake in that subquery's own predicates (wrong column,database_namevsquery_idswapped, a missingserver_id) passes this test green: the subquery just returns NULL and the fallback answers.This is the trap in
.github/REVIEW-TRAPS.md: "A test that constructs a 'four maintenance anomalies in one run' fixture is testing a shape no live run produces (#3709…). Fixtures should carry the population the engine actually emits, or say they do not."A second row for query 21 —
INSERT INTO query_store_text (server_id, database_name, query_id, query_sql_text, …)with the marker and the inlineQueryTextleft null — would exercise the arm that matters, and would also pin that the keyed lookup matches the projection's.