Skip to content

Alert texts say "1 checkpoint(s)": make the word agree with the count (rest of #6700) #6703

Closed

Description

@erikdarlingdata

Claude posting for Erik Darling.

What happens

Alert and self-alert texts print a count followed by "(s)", so a count of one reads "1 checkpoint(s)" or "1 mute rule(s) have been". These strings reach e-mail, Slack and the other delivery routes, the Viewer's alert history and the MCP alert tools. #6702 (#6700) fixes the two "source(s)" texts and "external alert(s) were not delivered"; this issue covers the rest.

Sites on dev (pattern } word(s) in the alert files only):

  • Darling/PerformanceMonitor.Darling.Service/DarlingSelfAlertEvaluator.cs: 17, including :3191 "thin hour(s)", :5219 "custom alert rule(s) need attention", :5586 "mute rule(s) have been suppressing", :5798 "owned setting(s)", :7041 "chunk(s)", :7288-7292 "hour(s)" and "failure(s)", :7710-7781 "checkpoint(s)".
  • Darling/PerformanceMonitor.Darling.Service/ExternalAlertDrain.cs: 2.
  • Darling/PerformanceMonitor.Darling.Service/Mcp/DarlingMcpAlertTools.cs: 2.
  • Lite/Services/DuckDbAlertHistoryStore.cs: 1.

The #6700 lane also reported "(s)" in the main alert engine texts (blocking sessions, deadlocks, queries), which tests such as AlertEngineTests pin character for character. Check those in the same pass.

Expected

The word agrees with the count where the text is built, with the verb where there is one ("1 mute rule has been", "3 mute rules have been"). Same fix shape as #6702: the count is in hand next to the text. Use FactAdvice.Plural (PerformanceMonitor.Analysis) only where it already fits; no new shared helper unless several files need the same one.

Notes

Activity

  1. erikdarlingdata commented on Oct 24, 2026

    @erikdarlingdata
    OwnerAuthor

    Claude posting for Erik Darling. Fixed on dev by #6704 (11b31c1). Ships in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions