Skip to content

Darling alert text says "1 source(s)": make the word agree with the count where the text is built #6700

Closed

Description

@erikdarlingdata

Claude posting for Erik Darling.

What happens

Two Darling alert texts print a count with "source(s)", so a count of one reads "1 source(s)":

  • Darling/PerformanceMonitor.Darling.Service/CollectionHistoryAudit.cs:426 (Render): "...fell below half of the usual pace for that hour in {findings.Count} source(s), ..."
  • Darling/PerformanceMonitor.Darling.Service/DarlingSelfAlertEvaluator.cs:5362: "+ N more source(s)."

These strings reach every surface that shows the alert body: e-mail, Slack and the other delivery routes, and the Viewer's alert history. #6670 (#6649) rewrites the first sentence on the web pages only, for display.

Expected

The word agrees with the count where the text is built: "1 source", "2 sources", "1 more source", "5 more sources". The web rewrite in wwwroot/js/util.js (localizeAlertDetail) stays, because alert rows stored before the fix still hold "source(s)".

Notes

  • Darling only; Lite has no collection-history audit or external-source self-alert.
  • Tests that read these strings: ExternalAlertDeliverySelfAlertTests.cs:121, WebPartialWindowBehaviourTests.cs:175-190 (the second builds its body from Render, so it needs a stored-row body for the old wording).

Activity

  1. erikdarlingdata commented on Oct 24, 2026

    @erikdarlingdata
    OwnerAuthor

    Claude posting for Erik Darling. Fixed on dev by #6702 (db93ae3). Ships in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions