Skip to content

FinOps RIGHT_SIZED explanation is a fixed sentence that can contradict its own numbers #6646

Closed

Description

@erikdarlingdata

Claude posting for Erik Darling.

What happens

When the FinOps Utilization verdict is RIGHT_SIZED, the explanation is always "CPU is moderately loaded ... and memory is well-utilized". The sentence does not depend on the numbers it prints. On an idle server it says the opposite of what the numbers show.

What I saw

v3.11.0 (1b6af51), get_finops view utilization, on an idle SQL Server 2022 test instance:

Field Value
verdict RIGHT_SIZED
avg_cpu_pct 0.1
p95_cpu_pct 0
max_cpu_pct 40
buffer pool share of RAM 8%

The explanation text:

CPU is moderately loaded (avg 0.1%, p95 0.0%) and memory is well-utilized (buffer pool uses 8% of physical RAM). No action needed.

An average of 0.1% is not moderate load, and 8% of RAM is not well-utilized. The verdict is RIGHT_SIZED only because one sample reached 40%. Per the #5704 notes, OVER_PROVISIONED needs an average below 15% and a maximum below 40%.

Where

  • PerformanceMonitor.Common/ServerHardwareScope.cs:235 RightSizedExplanation
  • Callers: Darling/PerformanceMonitor.Darling.Storage/FinOps/FinOpsUtilizationFigures.cs:87 and Lite/Controls/FinOpsTab.xaml.cs:542

Suggested fix

Build the RIGHT_SIZED sentence from the test that decided it. For this case, for example: "CPU averaged 0.1% (p95 0.0%), but one sample reached 40%, so this server is not rated over-provisioned. The buffer pool uses 8% of physical RAM." Say "moderately loaded" only when the average or p95 supports it.

A separate question for the maintainer: should one sample at 40% keep an otherwise idle server out of OVER_PROVISIONED? A p95 or a high percentile may suit that test better than the maximum.

How to verify

A unit test with avg 0.1, p95 0 and max 40 must not produce "moderately loaded" or "well-utilized".

Activity

  1. added
    bugSomething isn't working
    client-siteOwned by the client-site agents (other laptop). Local sessions never pick these up.
    on Oct 23, 2026
  2. erikdarlingdata commented on Oct 24, 2026

    @erikdarlingdata
    OwnerAuthor

    Claude posting for Erik Darling. Fixed on dev by #6666 (6800aea). Ships in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingclient-siteOwned by the client-site agents (other laptop). Local sessions never pick these up.owner:pm-worker-coordinatorLaptop coordinator session

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions