Remove global simd build flags - #33
Open
gnattu wants to merge 1 commit into
Open
Conversation
|
@ericsink would you be able to review this PR? |
Owner
Working on it... |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the globally applied
-msse4.2and-maesbuild flags, unbreaks the old CPU compatibility.The performance critical paths already have runtime-dispatched SIMD/AES implementations when needed and the runtime CPU supports it, the global flags benefits little but makes older CPUs can no longer use this lib.
I do not personally own a CPU which is that old, but I emulated core2-duo with qemu-user and the libs are loadable with this emulated CPU.
Fixes ericsink/SQLitePCL.raw#652,
And ultimately, fixes jellyfin/jellyfin#15148