Skip to content

fix: keep installer consent turn visible [closes BEAR-103] - #100

Merged
mergify[bot] merged 2 commits into
mainfrom
codex/BEAR-103-visible-installer-final
Jul 31, 2026
Merged

fix: keep installer consent turn visible [closes BEAR-103]#100
mergify[bot] merged 2 commits into
mainfrom
codex/BEAR-103-visible-installer-final

Conversation

@ericlitman

@ericlitman ericlitman commented Jul 31, 2026

Copy link
Copy Markdown
Owner

Summary

  • require the first guided-install consent turn's terminal final_answer to retain the complete welcome, readiness result, recommendation card, and question
  • forbid commentary-only cards and question-only terminal answers
  • keep failed compatibility checks equally self-contained without claiming readiness or asking for consent
  • restore focused contract coverage and record the user-visible fix in the changelog

Tests

  • go test ./cmd/threadbear -run 'TestPublishedInstallGuide' -count=1
  • go test ./...
  • go vet ./...
  • sh -n install.sh && sh -n site/install.sh
  • cmp -s INSTALL.md site/install
  • git diff --check
  • fresh live codex exec against the candidate guide and local dry run: the terminal message contained the full heading, orientation, readiness sentence, all six recommendation bullets, and consent question, followed immediately by turn completion
  • fresh read-only failure-path codex exec: the terminal message retained the complete welcome and truthful network failure, stated that nothing changed, and withheld the readiness claim, recommendation card, and consent question

Linear: BEAR-103

Closes BEAR-103

@ericlitman
ericlitman marked this pull request as ready for review July 31, 2026 23:21
@ericlitman
ericlitman marked this pull request as draft July 31, 2026 23:21

@mobilyze-open-swe-studio2 mobilyze-open-swe-studio2 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Open SWE Review: No issues found

Open SWE reviewed this PR and found no potential bugs to report.

Open in Web

@ericlitman
ericlitman marked this pull request as ready for review July 31, 2026 23:27
@ericlitman
ericlitman marked this pull request as draft July 31, 2026 23:27
@ericlitman
ericlitman marked this pull request as ready for review July 31, 2026 23:29
@mergify

mergify Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

  • Entered queue2026-07-31 23:30 UTC · Rule: default · triggered by merge protections
  • Checks skipped · PR is already up-to-date
  • Merged2026-07-31 23:30 UTC · at e41b1630a454f473f5ab984c72ec10c09c51383f

This pull request spent 12 seconds in the queue, including 1 second running CI.

Required conditions to merge
  • github-review-approved [🛡 GitHub repository ruleset rule Mergify automatic merge queue]
  • all of [🛡 Merge Protections rule Queue ready pull requests]:
  • any of [🛡 GitHub branch protection]:
    • check-success = verify
    • check-neutral = verify
    • check-skipped = verify
  • any of [🛡 GitHub branch protection]:
    • check-success = Open SWE Review
    • check-neutral = Open SWE Review
    • check-skipped = Open SWE Review
  • any of [🛡 GitHub repository ruleset rule Mergify automatic merge queue]:
    • check-success = @mergify/Mergify Merge Protections
    • check-neutral = @mergify/Mergify Merge Protections
    • check-skipped = @mergify/Mergify Merge Protections

@mergify
mergify Bot merged commit e0c18df into main Jul 31, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant