Repository navigation
Conversation
Refactor color retrieval methods to improve accuracy and add a method for finding the closest color. Change color value calculations from floor to round for better precision.
…n PSP42 v 2 Updated pad assignments and added new controls for PSP42, PSP42x, and Megaverb.
…ration validation error - Add Math.max() to ensure duration is at least 0.25 (quarter beat) - Prevents 'Parameter insertDuration must be > 0.0' error when duration is 0 - Fixes validation error at PadHandler.java:145 in executeCopy()
…peat, pan, recurrence, etc.) - executeCopy() now properly copies all note properties via registerExpectedNoteChange() - This triggers applyValues() in DrumSequenceMode which copies: chance, timbre, pressure, repeatCount, repeatVelocityCurve, pan, repeatVelocityEnd, recurrence, occurrence - Fixes issue where volume and other parameters were lost during pad copy
…to 0-127 range - Changed to use Math.round() for accurate velocity conversion - Velocity is now properly copied from noteStep.velocity() * 127 with rounding - Ensures volume/dynamics are preserved when copying between pads
Refactor PadHandler class to improve structure and readability. Update NoteData class to public for accessibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Refactor ColorLookup for improved color accuracy in Bitwig 6]
[Add LEXICON_PSP2 to SpecialVst3Devices enum]
[Update pom.xml for version and plugin changes]
[Fix: Properly copy note velocity by converting from normalized value …]
Akai Fire Copy & Paste - Correct Workflow
Lexicon PSP42 ver. 2 is now also supported